reames added a comment.
This seems to have landed a couple of days ago without problem, but if anyone
sees any weird effects in shared builds for Linux, this change is probably the
culprit. The last time I tried to do something like this, I had to back out my
change due to linker errors I neve
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276856: Adjust Registry interface to not require plugins to
export a registry (authored by john.brawn).
Repository:
rL LLVM
https://reviews.llvm.org/D21385
Files:
cfe/trunk/examples/AnnotateFunction
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
klimek added a reviewer: rnk.
klimek added a comment.
+Reid for a windows reviewer
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
john.brawn added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Ilod added a comment.
I don't have write access to SVN, so IIUC LLVM policy says I can't approve a
patch.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
john.brawn added a comment.
> Plugins tests are still disabled by lit.cfg I think, as it only checks for
> enable_shared, which is disabled. I suppose we could wait for both this and
> the SampleAnalyzerPlugin to be patched before enabling plugins tests if we
> have LLVM_EXPORT_SYMBOLS_FOR_PLUG
Ilod added a comment.
LGTM
Plugins tests are still disabled by lit.cfg I think, as it only checks for
enable_shared, which is disabled. I suppose we could wait for both this and the
SampleAnalyzerPlugin to be patched before enabling plugins tests if we have
LLVM_EXPORT_SYMBOLS_FOR_PLUGINS, as
john.brawn updated this revision to Diff 62684.
john.brawn added a comment.
Updated to not touch the sample analyzer plugin.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
Files:
cfe/trunk/examples/AnnotateFunctions/CMakeLists.txt
cfe/trunk/examples/PrintFunctionNames/CMakeLists.txt
john.brawn added a comment.
Created http://reviews.llvm.org/D21971 to make the sample analyzer plugin work.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
john.brawn added a comment.
In http://reviews.llvm.org/D21385#473163, @Ilod wrote:
> The PrintFunctionNames plugin works fine, but not the SampleAnalyzerPlugin?
> The checker-plugins test fails.
Argh, I hadn't noticed that the plugin tests depend on the 'plugins' feature,
and lit.cfg sets tha
Ilod added a comment.
The PrintFunctionNames plugin works fine, but not the SampleAnalyzerPlugin? The
checker-plugins test fails. Not sure, but I suppose it's because the
regitration method for checkers is different (a C method called
clang_registerCheckers is retrieved in the DLL from the main
john.brawn added a comment.
Commit r274365 should make extract_symbols.py work with Python 3.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
john.brawn added a comment.
> http://clang.llvm.org/get_started.html doesn't specify a version of Python,
> the LLVM webpage only say >= 2.7, and I ran the tests without any problem
> with Python 3 (but maybe some tests were automatically skipped?). Also,
> Python is also marked as only necessa
Ilod added a comment.
In http://reviews.llvm.org/D21385#472268, @john.brawn wrote:
> In http://reviews.llvm.org/D21385#471807, @Ilod wrote:
>
> > I gave up after this. I have Pyhton 3.5 64 bits, and was building clang
> > 32-bits on Windows with Visual Studio 2015 Update 2.
>
>
> python 3 isn't
john.brawn added a comment.
In http://reviews.llvm.org/D21385#471807, @Ilod wrote:
> I gave up after this. I have Pyhton 3.5 64 bits, and was building clang
> 32-bits on Windows with Visual Studio 2015 Update 2.
python 3 isn't supported when building llvm/clang, according to llvm's
CMakeLists
Ilod added a subscriber: Ilod.
Ilod added a comment.
Hello,
When I tried your patch and added LLVM_EXPORT_SYMBOLS_FOR_PLUGINS=ON, I had
multiple errors on your python scripts, like:
File "utils/extract_symbols.py", line 399, in
calling_convention_decoration = is_32bit_windows(libs[0]
john.brawn added a comment.
Ping
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john.brawn added a comment.
Ping.
Repository:
rL LLVM
http://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john.brawn created this revision.
john.brawn added reviewers: ehsan, reames, chapuni.
john.brawn added subscribers: llvm-commits, cfe-commits.
john.brawn set the repository for this revision to rL LLVM.
Herald added a subscriber: klimek.
Currently the Registry class contains the vestiges of a prev
20 matches
Mail list logo
