Re: [PATCH] D21240: Revise RenderScript attribute declaration

2016-06-10 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272438: Revise RenderScript attribute declaration (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21240?vs=60397&id=60411#toc Repository: rL LLVM http://reviews.llvm.org/D212

Re: [PATCH] D21240: Revise RenderScript attribute declaration

2016-06-10 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Comment at: include/clang/Basic/Attr.td:735 @@ -733,2 +734,3 @@ let Subjects = SubjectList<[Function]>; let Documentation = [Undocumented]

[PATCH] D21240: Revise RenderScript attribute declaration

2016-06-10 Thread Pirama Arumuga Nainar via cfe-commits
pirama created this revision. pirama added reviewers: aaron.ballman, rsmith. pirama added subscribers: srhines, cfe-commits. Address post-patch comments to r272342. - Rename the 'kernel' attribute's name - Idiomatically restrict the attribute to the 'RenderScript' LangOpt. http://reviews.llvm.or