Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

2016-06-27 Thread Jordan Rose via cfe-commits
jordan_rose closed this revision. jordan_rose added a comment. Committed as r273976. Repository: rL LLVM http://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

2016-06-27 Thread Ben Langmuir via cfe-commits
benlangmuir added a subscriber: benlangmuir. benlangmuir added a comment. LGTM Repository: rL LLVM http://reviews.llvm.org/D2 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21111: Avoid accessing an invalid PresumedLoc

2016-06-22 Thread Jordan Rose via cfe-commits
jordan_rose added a comment. *ping* I'm happy to have someone else review this (or "LGTM" this), but it's so small that I'm not sure who else to ask. I'd rather not just commit it cause it's been a while since I've touched Clang. Repository: rL LLVM http://reviews.llvm.org/D2 __

[PATCH] D21111: Avoid accessing an invalid PresumedLoc

2016-06-07 Thread Jordan Rose via cfe-commits
jordan_rose created this revision. jordan_rose added a reviewer: rsmith. jordan_rose added a subscriber: cfe-commits. jordan_rose set the repository for this revision to rL LLVM. DiagnosticNoteRenderer asserts trying to emit its "while building module Foo imported from bar.h:5" note when the pres