Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

This revision was automatically updated to reflect the committed changes. Closed by commit rL272993: [clang-tidy] readability-identifier-naming - Support for Macros (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D21020?vs=61071&id=61074#toc Repository: rL LLVM http:/

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

alexfh added a comment. In http://reviews.llvm.org/D21020#460734, @JamesReynolds wrote: > Thanks! All fixed now. Could you land this for me please? Sure, will do. Thank you for working on this! http://reviews.llvm.org/D21020 ___ cfe-commits maili

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. Thanks! All fixed now. Could you land this for me please? http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked 2 inline comments as done. Comment at: clang-tidy/readability/IdentifierNamingCheck.h:98 @@ +97,3 @@ + + /// Add a usage of a macro if it already has a violation. + void expandMacro(const Token &MacroNameTok, const MacroInfo *MI); Fixed this

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 61071. JamesReynolds added a comment. Fixed nits. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp clang-tidy/readability/IdentifierNamingCheck.h docs/ReleaseNotes.rst test/clang-tidy/readability-identifie

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good with a couple of nits. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:808 @@ +807,3 @@ + addUsage(NamingCheckFailures, ID, Range); + return; +}

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 60058. JamesReynolds marked an inline comment as not done. JamesReynolds added a comment. Missed one modification in last update. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp clang-tidy/readability/Identif

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.h:89 @@ +88,3 @@ + + typedef std::pair NamingCheckId; + I think I thought that this wouldn't get picked up by the specialization machinery - but you're right, a typedef

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 60056. JamesReynolds marked 5 inline comments as done. JamesReynolds added a comment. Applied suggested code changes. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp clang-tidy/readability/IdentifierNamingChe

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

alexfh added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:142 @@ +141,3 @@ +SourceManager &SM(PP->getSourceManager()); +if (!SM.isInMainFile(MacroNameTok.getLocation())) + return; I'm not sure the check currently refus

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 60010. JamesReynolds added a comment. Changed the clang-tidy release notes addition to be in alphabetical order. http://reviews.llvm.org/D21020 Files: clang-tidy/readability/IdentifierNamingCheck.cpp clang-tidy/readability/IdentifierNamingCheck.h

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds marked an inline comment as done. JamesReynolds added a comment. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:262 @@ -261,1 +261,3 @@ +- Updated `readability-identifier-naming-check + `_ Please put this not in alphab

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds updated this revision to Diff 59857. JamesReynolds added a comment. Thanks Eugene, I've added a comment into docs/ReleaseNotes.rst to say this is in. I'll create a BugZilla account to update PR. I've also added a new test and code to create FixIts for uses of the Macros as well as

Re: [PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to mention improvement in docs/ReleaseNotes.rst. Please close PR23198 after commit. http://reviews.llvm.org/D21020 ___ cfe-commits mailing list c

[PATCH] D21020: [clang-tidy] readability-identifier-naming - Support for Macros

JamesReynolds created this revision. JamesReynolds added a reviewer: alexfh. JamesReynolds added a subscriber: cfe-commits. Added support for macro definitions. -- 1. Added a pre-processor callback to catch macro definitions 2. Changed the type of the failure map so that macros and declarations c