Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Alexander Kornienko via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271739: [clang-tidy] modernize-use-auto: don't remove stars by default (authored by alexfh). Changed prior to commit: http://reviews.llvm.org/D20917?vs=59599&id=59625#toc Repository: rL LLVM http://

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Alexander Kornienko via cfe-commits
alexfh added inline comments. Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list. -if (Dec == *D->decl_begin()) - conti

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Piotr Padlewski via cfe-commits
Prazek added a subscriber: Prazek. Prazek added a comment. besides it lgtm Comment at: clang-tidy/modernize/UseAutoCheck.cpp:338 @@ -329,8 +337,3 @@ -// Remove explicitly written '*' from declarations where there's more than -// one declaration in the declaration list.

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D20917#447046, @sbenza wrote: > Is it a typo in the description when it says that when RemoveStar is on we > will write 'auto*' instead if 'auto'? Yep, the whole patch description is a typo, fixed ;) http://reviews.llvm.org/D20917 ___

Re: [PATCH] D20917: [clang-tidy] modernize-use-auto: don't remove stars by default

2016-06-03 Thread Alexander Kornienko via cfe-commits
alexfh updated this revision to Diff 59599. alexfh marked an inline comment as done. alexfh added a comment. - Updated formatting in the doc. http://reviews.llvm.org/D20917 Files: clang-tidy/modernize/UseAutoCheck.cpp clang-tidy/modernize/UseAutoCheck.h docs/clang-tidy/checks/modernize-us