Re: [PATCH] D20836: [CUDA] Conservatively mark inline asm as convergent.

2016-05-31 Thread Artem Belevich via cfe-commits
tra added a comment. I guess we would not be able to remove convergent from inline asm automatically. Do we need a way to explicitly remove convergent from inline asm? http://reviews.llvm.org/D20836 ___ cfe-commits mailing list cfe-commits@lists.ll

Re: [PATCH] D20836: [CUDA] Conservatively mark inline asm as convergent.

2016-05-31 Thread Justin Lebar via cfe-commits
jlebar added a comment. In http://reviews.llvm.org/D20836#444911, @tra wrote: > I guess we would not be able to remove convergent from inline asm > automatically. Do we need a way to explicitly remove convergent from inline > asm? We can think about it. I'm not sure it will make a big differ

Re: [PATCH] D20836: [CUDA] Conservatively mark inline asm as convergent.

2016-05-31 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271336: [CUDA] Conservatively mark inline asm as convergent. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D20836?vs=59130&id=59133#toc Repository: rL LLVM http://reviews.ll

[PATCH] D20836: [CUDA] Conservatively mark inline asm as convergent.

2016-05-31 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. This is particularly important because a some convergent CUDA intrinsics (e.g. __shfl_down) are implemented in terms of inline asm. http://reviews.llvm.org/D20836 Files: lib/CodeGen/CGStmt.cpp