Re: [PATCH] D20819: [find-all-symbols] remove dots in SymbolInfo file paths.

2016-05-31 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271302: [find-all-symbols] remove dots in SymbolInfo file paths. (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D20819?vs=59075&id=59091#toc Repository: rL LLVM http://review

Re: [PATCH] D20819: [find-all-symbols] remove dots in SymbolInfo file paths.

2016-05-31 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. I think this is ok, mainly because the clean paths are explicitly for user code, where users usually like to have, well, clean paths. http://reviews.llvm.org/D20819 ___

Re: [PATCH] D20819: [find-all-symbols] remove dots in SymbolInfo file paths.

2016-05-31 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. Adding Manuel as a second opinion. I think this is fine but paths are a messy problem, in particular removing .. can break symlinked directories. http://reviews.llvm.org/D20819 ___ cfe-commits mailing list cfe-commits@lists