Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 64525. EricWF added a comment. Add test for PR28469 and remove __tree from the UBSAN blacklist. https://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp test/libcxx/c

Re: [PATCH] D20786: Fix undefined behavior in __tree

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I'm not really happy with this situation, but I don't see how to improve this patch. https://reviews.llvm.org/D20786 ___ cfe-commits m

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF added a reviewer: howard.hinnant. EricWF added a subscriber: howard.hinnant. EricWF added a comment. Adding Howard to the reviewers. @howard.hinnant Feel free to take a look if your interested. @mclow.lists Any comments? http://reviews.llvm.org/D20786

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 63267. EricWF added a comment. Fix merge conflicts in __config. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp test/libcxx/containers/associative/tree_left_r

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF added a comment. @mclow.lists What would you like to see in order to help this patch proceed? http://reviews.llvm.org/D20786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 58933. EricWF added a comment. Fix some code I broke last iteration. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp test/libcxx/containers/associative/tree_l

Re: [PATCH] D20786: Fix undefined behavior in __tree

EricWF updated this revision to Diff 58931. EricWF added a comment. Fix __tree algorithm tests. http://reviews.llvm.org/D20786 Files: include/__config include/__tree test/libcxx/containers/associative/tree_balance_after_insert.pass.cpp test/libcxx/containers/associative/tree_left_rotate

[PATCH] D20786: Fix undefined behavior in __tree

EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. This patch attempts to fix the undefined behavior in __tree by changing the node pointer types used throughout. The pointer types are changed for raw pointers in the current ABI and for fa