Re: [PATCH] D20729: [mips] Compact branch policy setting

2016-05-27 Thread Simon Dardis via cfe-commits
sdardis added a comment. Thanks for the review. Repository: rL LLVM http://reviews.llvm.org/D20729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20729: [mips] Compact branch policy setting

2016-05-27 Thread Simon Dardis via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271000: [mips] Compact branch policy setting. (authored by sdardis). Changed prior to commit: http://reviews.llvm.org/D20729?vs=58778&id=58789#toc Repository: rL LLVM http://reviews.llvm.org/D20729

Re: [PATCH] D20729: [mips] Compact branch policy setting

2016-05-27 Thread Simon Atanasyan via cfe-commits
atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM with some nits Comment at: lib/Driver/Tools.cpp:1446 @@ +1445,3 @@ +CmdArgs.push_back(Args.MakeArgString("-mips-compact-branches=" + Val)); + + } else

[PATCH] D20729: [mips] Compact branch policy setting

2016-05-27 Thread Simon Dardis via cfe-commits
sdardis created this revision. sdardis added reviewers: dsanders, atanasyan. sdardis added a subscriber: cfe-commits. Herald added a reviewer: vkalintiris. Herald added a subscriber: sdardis. This patch adds the commandline option -mcompact-branches={never,optimal,always), which controls how LLVM