Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

This revision was automatically updated to reflect the committed changes. Closed by commit rL273440: Add support for /Ob1 and -finline-hint-functions flags (authored by hans). Changed prior to commit: http://reviews.llvm.org/D20647?vs=61418&id=61565#toc Repository: rL LLVM http://reviews.ll

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

Ilod added a comment. Thanks. I will let you submit it for me if everything seems ok. http://reviews.llvm.org/D20647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

hans accepted this revision. hans added a comment. In http://reviews.llvm.org/D20647#463590, @Ilod wrote: > Fixed passing argument from clang driver to cc1. > Added driver tests. lgtm, thanks! http://reviews.llvm.org/D20647 ___ cfe-commits maili

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

Ilod marked 2 inline comments as done. Ilod added a comment. http://reviews.llvm.org/D20647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

Ilod updated this revision to Diff 61418. Ilod added a comment. Fixed passing argument from clang driver to cc1. Added driver tests. http://reviews.llvm.org/D20647 Files: include/clang/Driver/CLCompatOptions.td include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

Ilod marked an inline comment as done. Comment at: test/Driver/cl-options.c:283 @@ -282,3 +282,2 @@ // RUN:/nologo \ -// RUN:/Ob1 \ // RUN:/openmp- \ hans wrote: > You're removing it from the ignored flags here, but I don't see any code > change or

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

hans added inline comments. Comment at: test/Driver/cl-options.c:283 @@ -282,3 +282,2 @@ // RUN:/nologo \ -// RUN:/Ob1 \ // RUN:/openmp- \ You're removing it from the ignored flags here, but I don't see any code change or test for how clang-cl's sup

Re: [PATCH] D20647: Add support for /Ob1 and -finline-hint-functions flags

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Another consequence of doing it this way is that the /Ob1 decision will survive through LTO, for better or worse. In http://reviews.llvm.org/D20647#461135, @probinson wrote: > I'm still bemus