Re: [PATCH] D20597: Speed up check by using a recursive visitor.

2016-05-25 Thread Samuel Benzaquen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270714: Speed up check by using a recursive visitor. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D20597?vs=58438&id=58440#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

2016-05-25 Thread Samuel Benzaquen via cfe-commits
sbenza updated this revision to Diff 58438. sbenza marked an inline comment as done. sbenza added a comment. Reformat code http://reviews.llvm.org/D20597 Files: clang-tidy/readability/FunctionSizeCheck.cpp clang-tidy/readability/FunctionSizeCheck.h Index: clang-tidy/readability/FunctionSiz

Re: [PATCH] D20597: Speed up check by using a recursive visitor.

2016-05-24 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thank you! Comment at: clang-tidy/readability/FunctionSizeCheck.cpp:25 @@ +24,3 @@ + bool TraverseStmt(Stmt* Node) { +if (!Node) return Base::TraverseStmt(Node); + --

[PATCH] D20597: Speed up check by using a recursive visitor.

2016-05-24 Thread Samuel Benzaquen via cfe-commits
sbenza created this revision. sbenza added a reviewer: alexfh. sbenza added a subscriber: cfe-commits. Use a recursive visitor instead of forEachDescendant() matcher. The latter requires several layers of virtual function calls for each node and it is more expensive than the visitor. Benchmark res