Re: [PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

2016-05-20 Thread Adrian McCarthy via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL270226: Eliminate unnecessary file access checks in Clang driver on Windows (authored by amccarth). Changed prior to commit: http://reviews.llvm.org/D20454?vs=57872&id=57936#toc Repository: rL LLVM

Re: [PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

2016-05-19 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20454 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D20454: Eliminate unnecessary file access checks in Clang driver on Windows

2016-05-19 Thread Adrian McCarthy via cfe-commits
amccarth created this revision. amccarth added a reviewer: majnemer. amccarth added a subscriber: cfe-commits. This fixes the problem where the driver will look for cl.exe.exe while walking the PATH. I looked into changing the Windows implementation of llvm::sys::fs::can_execute(), but there wa