Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

2016-05-13 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Great! Lgtm http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

2016-05-13 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. In http://reviews.llvm.org/D20261#430151, @rnk wrote: > Will this put the libraries in build/Release/bin/../lib/. aka > build/Release/lib, or will they collide between build types? If I get your question correctly, they won't collide since the first folder below

Re: [PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

2016-05-13 Thread Reid Kleckner via cfe-commits
rnk added a comment. Will this put the libraries in build/Release/bin/../lib/. aka build/Release/lib, or will they collide between build types? http://reviews.llvm.org/D20261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D20261: [compiler-rt] Fix multi-configuration output paths

2016-05-13 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. When using a multi-configuration build (i.e. MSVC) the output path where libraries are dropped is incorrect. Example: ``` C:\src\llvm\examples>d:\src\llvm\build\Release\bin\clang-cl.exe -fsa