rsmith added a comment.
In http://reviews.llvm.org/D20207#428486, @aaron.ballman wrote:
> Generally, I think this looks good. It will definitely help with AST
> matchers. Richard, do you have any problems with this approach?
Not at all. This would be a nice improvement even if it didn't also p
etienneb marked an inline comment as done.
etienneb added a comment.
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @file OperationKinds.def
+///
aaron.ballman wrote:
> Do we use @file doxygen comments usually? I'm not certain if I've
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Generally, I think this looks good. It will definitely help with AST matchers.
Richard, do you have any problems with this approach?
Comment at: include/clang/AST/OperationKinds.def:15
@@ +14,3 @@
+//
+/// @
etienneb updated this revision to Diff 57045.
etienneb added a comment.
remove incorrect patch upload (sorry)
http://reviews.llvm.org/D20207
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/OperationKinds.h
include/clang/module.modulemap
lib/AST/Expr.cpp
Index: lib/AST/Exp
etienneb updated this revision to Diff 57043.
etienneb added a comment.
Herald added a subscriber: klimek.
rebase over AST modifications
http://reviews.llvm.org/D20207
Files:
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Marshallers.h
lib/ASTMatchers/Dynamic/Registry.cpp
etienneb created this revision.
etienneb added reviewers: klimek, aaron.ballman.
etienneb added subscribers: cfe-commits, alexfh, sbenza.
This patch moves the enum definitions to a definition (.def) file.
These modifications provide way to list enumerator of a given type.
As an example, this all
