bruno closed this revision.
bruno added a comment.
Thanks Ben!
Committed r269502
http://reviews.llvm.org/D20194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
bruno updated this revision to Diff 57263.
bruno added a comment.
Updated after Ben's suggestions!
http://reviews.llvm.org/D20194
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/ModuleDependencyCollector.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/crash-recovery/Frameworks/A.framewo
benlangmuir added a comment.
Let's move the code looks up the alternate name out of the ModuleMap parser,
and into the dependency collector callbacks. This feels like an implementation
detail of the dependency collector. We could add a new callback specifically
for umbrella headers and handle
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make sure we also collect the right header files inside them.
More info on (2):
Consider a dummy fra
