etienneb added a comment.
In http://reviews.llvm.org/D20180#427893, @rnk wrote:
> In http://reviews.llvm.org/D20180#427840, @alexfh wrote:
>
> > `inline` seems to be completely redundant here. Can you try removing it and
> > running whatever build configurations were failing without
> > http://
rnk added a comment.
In http://reviews.llvm.org/D20180#427840, @alexfh wrote:
> `inline` seems to be completely redundant here. Can you try removing it and
> running whatever build configurations were failing without
> http://reviews.llvm.org/D20182?
My bad, it's explicit function template sp
etienneb added a comment.
I'm sure you're right: they are redundant keywords.
I'm preparing the revert patch, and I'm running tests over multiple build types.
Repository:
rL LLVM
http://reviews.llvm.org/D20180
___
cfe-commits mailing list
cfe-com
alexfh added a subscriber: alexfh.
alexfh added a comment.
`inline` seems to be completely redundant here. Can you try removing it and
running whatever build configurations were failing without
http://reviews.llvm.org/D20182?
Repository:
rL LLVM
http://reviews.llvm.org/D20180
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL269224: [tooling] Fix missing inline keyworkd, breaking
build bot. (authored by etienneb).
Changed prior to commit:
http://reviews.llvm.org/D20180?vs=56949&id=56954#toc
Repository:
rL LLVM
http://re
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
I don't see how this could be causing the problem, but it's worth a try. They
should be marked inline anyway.
http://reviews.llvm.org/D20180
___
etienneb created this revision.
etienneb added a reviewer: rnk.
etienneb added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
The missing keyword "inline" is causing some buildbot to fail.
The symbol is not available.
see:
http://lab.llvm.org:8011/builders/clang-ppc64be-linux-mult
