Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

2016-05-11 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269162: [find-all-symbols] Slim SymbolInfo. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20095?vs=56725&id=56862#toc Repository: rL LLVM http://reviews.llvm.org/D20095 Fi

Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

2016-05-11 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D20095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

2016-05-10 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 56725. hokein marked an inline comment as done. hokein added a comment. Address comments. http://reviews.llvm.org/D20095 Files: include-fixer/InMemoryXrefsDB.cpp include-fixer/XrefsDBManager.cpp include-fixer/YamlXrefsDB.cpp include-fixer/find-all-sy

Re: [PATCH] D20095: [find-all-symbols] Slim SymbolInfo.

2016-05-10 Thread Benjamin Kramer via cfe-commits
bkramer added inline comments. Comment at: include-fixer/find-all-symbols/SymbolInfo.cpp:95 @@ -98,1 +94,3 @@ + auto RHS = std::tie(Symbol.Name, Symbol.FilePath, Symbol.LineNumber); + return LHS != RHS ? LHS < RHS : Contexts < Symbol.Contexts; } Does folding Co