Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-11 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269167: [include-fixer] Add basic documentation. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20094?vs=56856&id=56867#toc Repository: rL LLVM http://reviews.llvm.org/D20094

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-11 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: docs/include-fixer.rst:16 @@ +15,3 @@ + +To use :program:`clang-include-fixer` two databases are required, both can be +generated with existing tools. -

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-11 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 56856. bkramer added a comment. Address review comments. http://reviews.llvm.org/D20094 Files: docs/include-fixer.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/i

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-11 Thread Benjamin Kramer via cfe-commits
bkramer marked 2 inline comments as done. Comment at: docs/include-fixer.rst:48 @@ +47,3 @@ +... wait as clang indexes the code base ... + $ ln -s $PWD/find_all_symbols_db.yaml path/to/llvm/source/ # Link database into the source tree. + $ cd path/to/llvm/source ---

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-10 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: docs/include-fixer.rst:36 @@ +35,3 @@ + +The include fixer contains :program:`find-all-symbols`, a tool to create a +symbol database in YAML format from a compilation database by parsing all A extra space before a. =

Re: [PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-10 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 56687. bkramer added a comment. de-freud http://reviews.llvm.org/D20094 Files: docs/include-fixer.rst docs/index.rst Index: docs/index.rst === --- docs/index.rst +++ docs/index.rst @@ -21,

[PATCH] D20094: [include-fixer] Add basic documentation.

2016-05-10 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: hokein, djasper, klimek. bkramer added a subscriber: cfe-commits. http://reviews.llvm.org/D20094 Files: docs/include-fixer.rst docs/index.rst Index: docs/index.rst === ---