[PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2020-10-15 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added inline comments. Comment at: cfe/trunk/lib/Sema/SemaType.cpp:2067 + S.LangOpts.GNUMode || + S.LangOpts.OpenCL).isInvalid(); } This looks wrong to me. The OpenCL rule

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-06-06 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271971: [OPENCL] Fix wrongly vla error for OpenCL array. (authored by pxl). Changed prior to commit: http://reviews.llvm.org/D20090?vs=58932&id=59823#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-06-03 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! http://reviews.llvm.org/D20090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-29 Thread Xiuli PAN via cfe-commits
pxli168 updated this revision to Diff 58932. pxli168 added a comment. Make all tests in OpenCL 2.0. http://reviews.llvm.org/D20090 Files: lib/AST/ExprConstant.cpp lib/Sema/SemaType.cpp test/CodeGenOpenCL/vla.cl Index: test/CodeGenOpenCL/vla.cl

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-27 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: test/CodeGenOpenCL/vla.cl:1 @@ +1,2 @@ +// RUN: %clang_cc1 -emit-llvm -O0 -o - %s | FileCheck %s +// RUN: %clang_cc1 -emit-llvm -O0 -cl-std=CL2.0 -DCL20 -o - %s | FileCheck %s --check-prefix=CL20 pxli168 wrote: > Anast

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-26 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntegerC

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-12 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntege

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-10 Thread Xiuli PAN via cfe-commits
pxli168 added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntegerC

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-10 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaType.cpp:2055 @@ -2054,3 +2054,3 @@ - return S.VerifyIntegerConstantExpression(ArraySize, &SizeVal, Diagnoser, - S.LangOpts.GNUMode).isInvalid(); + return S + .VerifyIntege

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-10 Thread Alexey Bader via cfe-commits
bader accepted this revision. bader added a reviewer: bader. bader added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

Re: [PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-10 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. LGTM. Thanks. http://reviews.llvm.org/D20090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20090: [OPENCL] Fix wrongly vla error for OpenCL array.

2016-05-10 Thread Xiuli PAN via cfe-commits
pxli168 created this revision. pxli168 added reviewers: Anastasia, yaxunl. pxli168 added subscribers: cfe-commits, bader. OpenCL should support array with const value size length, those const varibale in global and constant address space and variable in constant address space. http://reviews.ll