aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the work on this! I've commit in r269662
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
hintonda added a comment.
Great, thanks again. This has been a great learning experience.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Okay, back to looking good. :-) I will commit on your behalf, since I'm back to
somewhere with source access again.
http://reviews.llvm.org/D20052
___
hintonda updated this revision to Diff 57356.
hintonda added a comment.
Revert back to previous version.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchers
hintonda added a comment.
Great, that's exactly what I needed. I'll revert back to the previous version.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
aaron.ballman added a comment.
In http://reviews.llvm.org/D20052#430903, @hintonda wrote:
> Great, unless() was what I was missing. I'll refactor along those lines.
>
> As for what I'm trying to achieve, I want a set containing "throw()" and
> another set containing "throw(something)". If ther
hintonda added a comment.
Great, unless() was what I was missing. I'll refactor along those lines.
As for what I'm trying to achieve, I want a set containing "throw()" and
another set containing "throw(something)". If there's a cleaner way to achieve
that with an existing matcher, please let
aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.
I'm not keen on the new direction this patch has taken.
`hasDynamicExceptionSpec(isThrow())` is quite novel. What is the problem you
are trying to solve with this?
==
hintonda updated this revision to Diff 57290.
hintonda added a comment.
- Added new isThrow matcher to complement isNoThrow, and changed
hadDynamicExceptionSpec to take a parameter, e.g., isThrow() or isNoThrow().
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
incl
hintonda added a comment.
Great, thanks. Btw, I don't have commit access, so could you land it for me?
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Wed, May 11, 2016 at 3:58 PM, don hinton wrote:
> hintonda added a comment.
>
> Great, thanks. Btw, I don't have commit access, so could you land it for me?
Normally, yes, but I'm traveling this week and don't have a computer
that has the source code on it right now. If someone other than me
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(
hintonda added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(FunctionDecl, hasDynamicExceptionSpec) {
+ if (const auto *FnTy = Node.getType()->getAs())
--
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3229
@@ +3228,3 @@
+/// matches the declarations of j, k, and l, but not f, g, h, or i.
+AST_MATCHER(FunctionDecl, hasDynamicExcept
hintonda updated this revision to Diff 56522.
hintonda added a comment.
- Added test, re-generated documentation, and add new matcher to the dynamic
matchers registry.
http://reviews.llvm.org/D20052
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTM
alexfh added a comment.
Please add tests, re-generate documentation and add the matcher to the dynamic
matchers registry. See http://reviews.llvm.org/D19871 for an example.
http://reviews.llvm.org/D20052
___
cfe-commits mailing list
cfe-commits@lis
hintonda created this revision.
hintonda added a reviewer: alexfh.
hintonda added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Add new ASTMatcher that matches dynamic exception specifications.
http://reviews.llvm.org/D20052
Files:
include/clang/ASTMatchers/ASTMatchers.h
Index
17 matches
Mail list logo
