etienneb added a comment.
I added the "using statements".
landing.
Comment at: include/clang/Tooling/Fixit.h:35
@@ +34,3 @@
+///used by the following template abstractions.
+inline SourceRange getSourceRange(const SourceRange &Range) { return Range; }
+
etienneb updated this revision to Diff 56907.
etienneb marked an inline comment as done.
etienneb added a comment.
fix nits
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.txt
unittests/T
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: unittests/Tooling/FixItTest.cpp:37
@@ +36,3 @@
+EXPECT_EQ("foo(x, y)",
+ tooling::fixit::getText(CE->getSourceRange(), *Context));
+
-
etienneb updated this revision to Diff 56826.
etienneb added a comment.
nits
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/FixItTest.cpp
Index: unittests/Tooling/
etienneb updated this revision to Diff 56825.
etienneb marked 5 inline comments as done.
etienneb added a comment.
address alexfh comments
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/FixIt.h
lib/Tooling/CMakeLists.txt
lib/Tooling/FixIt.cpp
unittests/Tooling/CMakeLists.tx
alexfh added inline comments.
Comment at: include/clang/Tooling/Fixit.h:1
@@ +1,2 @@
+//===--- FixIt.h - FixIt Hint utilities -*- C++
-*-===//
+//
nit: s/FixIt Hint/FixItHint/, since this is a reference to the type.
Comm
etienneb updated this revision to Diff 56790.
etienneb added a comment.
more unittests
http://reviews.llvm.org/D19941
Files:
include/clang/Tooling/Fixit.h
lib/Tooling/CMakeLists.txt
lib/Tooling/Fixit.cpp
unittests/Tooling/CMakeLists.txt
unittests/Tooling/FixitTest.cpp
Index: unittest
