seaneveson added a subscriber: seaneveson.
seaneveson closed this revision.
seaneveson added a comment.
Committed: http://reviews.llvm.org/rL270849
http://reviews.llvm.org/D19866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
FlameTop added a comment.
Thank you for the acceptance.
May I please ask you to commit the change for me as I do not have commit access?
cheers
Phil Camp
http://reviews.llvm.org/D19866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
FlameTop updated this revision to Diff 56591.
FlameTop added a comment.
Thank you for your review. I have removed the changes to the bug description.
Apologies, I did not realize it would alter the hash.
http://reviews.llvm.org/D19866
Files:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/Stack
dcoughlin added inline comments.
Comment at:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:229
@@ -228,3 +228,3 @@
BT_stackleak.reset(
-new BuiltinBug(this, "Stack address stored into global variable",
- "Stack address
zaks.anna added a comment.
Thanks for fixing!
Devin, what do you think about the BugType wording?
Comment at:
llvm/tools/clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp:229
@@ -228,3 +228,3 @@
BT_stackleak.reset(
-new BuiltinBug(this, "Stack address s
FlameTop created this revision.
FlameTop added reviewers: zaks.anna, dcoughlin.
FlameTop added a subscriber: cfe-commits.
Leaking a stack address via a static variable refers to it in the diagnostic as
a 'global'. This patch corrects the diagnostic for static variables.
Patch by Phil Camp, SN S
