RE: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread Stephan T. Lavavej via cfe-commits
[David Majnemer] > Er, I don't think mingw provides _mktemp_s. Yeah, I don't know what needs to be done for MinGW. (I avoided using _mktemp for MSVC because I knew it would complain about "security".) I am pretty sure that this code was already broken for MinGW - I grepped and found no inclusio

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D19702#416314, @majnemer wrote: > Er, I don't think mingw provides _mktemp_s. I went back to the old method for MinGW in r267968 just to be safe. Thanks for the input. http://reviews.llvm.org/D19702 ___

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread David Majnemer via cfe-commits
Er, I don't think mingw provides _mktemp_s. On Thu, Apr 28, 2016 at 5:57 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > EricWF closed this revision. > EricWF added a comment. > > r267963. > > > http://reviews.llvm.org/D19702 > > > > __

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r267963. http://reviews.llvm.org/D19702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM but I don't know much about Windows or MinGW. http://reviews.llvm.org/D19702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D19702: [libcxx] [test] Fix get_temp_file_name() to compile for Windows.

2016-04-28 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix get_temp_file_name() to compile for Windows. It was including but attempting to use GetTempPath() and GetTempFileName(), which are provided by . Instead