Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF added a comment. In http://reviews.llvm.org/D19698#416315, @rsmith wrote: > In http://reviews.llvm.org/D19698#416309, @EricWF wrote: > > > Most tests pretty much rely on getting dragged in indirectly, > > same thing with and the bits of we actually define in > > . > > > There are also

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

rsmith added a comment. In http://reviews.llvm.org/D19698#416309, @EricWF wrote: > Most tests pretty much rely on getting dragged in indirectly, > same thing with and the bits of we actually define in > . There are also a few symbols that libc++ defines in the wrong header and then #inclu

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a comment. > I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look > into this further tonight. It has fix_includes.py script, but I encountered quite a lot of false positives, so I prefer to fix problems manually. http://reviews.llvm.org/D19698

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF added a comment. In http://reviews.llvm.org/D19698#416306, @rsmith wrote: > In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote: > > > It'll be good idea to run Include What You Use > > to make sure > > that all d

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

rsmith added a subscriber: rsmith. rsmith added a comment. In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote: > It'll be good idea to run Include What You Use > to make sure > that all dependencies are explicit. You

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF closed this revision. EricWF added a comment. r267958. http://reviews.llvm.org/D19698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Woops. My bad. http://reviews.llvm.org/D19698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. It'll be good idea to run Include What You Use to make sure that all dependencies are explicit. http://reviews.llvm.org/D19698 __

[PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Need to include for std::unique_ptr. Fixes MSVC "error C2039: 'unique_ptr': is not a member of 'std'". http://reviews.llvm.org/D19698 Files: test/std/utili