Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

2016-04-29 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268017: [include-fixer] Add Yaml database integration. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D19648?vs=55412&id=3#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

2016-04-28 Thread Haojian Wu via cfe-commits
hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D19648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

2016-04-28 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 55412. hokein added a comment. Fix a nit. http://reviews.llvm.org/D19648 Files: include-fixer/CMakeLists.txt include-fixer/YamlXrefsDB.cpp include-fixer/YamlXrefsDB.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/Inputs/fake_yaml_db.y

Re: [PATCH] D19648: [include-fixer] Add Yaml database integration.

2016-04-28 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Nice. Ship it! Comment at: include-fixer/YamlXrefsDB.h:25 @@ +24,3 @@ +public: + YamlXrefsDB(const std::string &FilePath); + StringRef instead of std::stri