Re: [PATCH] D19623: [libc++] Initialize local doubles to 0.0.

2016-04-27 Thread Howard Hinnant via cfe-commits
howard.hinnant added a subscriber: howard.hinnant. howard.hinnant added a comment. When in doubt, I find initializing to nan a safe thing to do. Either the code is correct, or the nan will find the bug. http://reviews.llvm.org/D19623 ___ cfe-commi

Re: [PATCH] D19623: [libc++] Initialize local doubles to 0.0.

2016-04-27 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT added a comment. I'd be happy to deal with this in another way. Would you accept _MSC_VER-guarded pragmas to silence such warnings? I didn't see an easy way to rework the logic here so that the variables are obviously initialized on every codepath, which would be the ideal pragma-less

Re: [PATCH] D19623: [libc++] Initialize local doubles to 0.0.

2016-04-27 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. I don't know how the libc++ folks feel about this, but our usual policy in Clang and LLVM is that we don't add bogus initializers to shut up incorrect "maybe used uninitialized" compiler warnings, because these initializers prevent tool

[PATCH] D19623: [libc++] Initialize local doubles to 0.0.

2016-04-27 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libc++] Initialize local doubles to 0.0. (Zero is a strict subset of garbage.) Fixes MSVC "warning C4701: potentially uninitialized local variable 'meow' used". http://revi