Re: [PATCH] D19459: Cleanup redundant expression in InstCombineAndOrXor.

2016-04-25 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. LGTM http://reviews.llvm.org/D19459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19459: Cleanup redundant expression in InstCombineAndOrXor.

2016-04-25 Thread Etienne Bergeron via cfe-commits
etienneb added a comment. thx Reid. added the appropriate reviewer. http://reviews.llvm.org/D19459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19459: Cleanup redundant expression in InstCombineAndOrXor.

2016-04-25 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm FYI David Majnemer is a good reviewer for InstCombine. http://reviews.llvm.org/D19459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D19459: Cleanup redundant expression in InstCombineAndOrXor.

2016-04-23 Thread Etienne Bergeron via cfe-commits
etienneb created this revision. etienneb added a reviewer: rnk. etienneb added a subscriber: cfe-commits. The expression is redundant on both side of operator |. detected by : http://reviews.llvm.org/D19451 http://reviews.llvm.org/D19459 Files: lib/Transforms/InstCombine/InstCombineAndOrXor.c