Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-22 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware marked 9 inline comments as done. baloghadamsoftware added a comment. http://reviews.llvm.org/D19357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-22 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware updated this revision to Diff 54642. baloghadamsoftware added a comment. Updated according to the comments. http://reviews.llvm.org/D19357 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/A

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Thanks for doing this! I think we want the version that iterates all parents. Otherwise it will have problems with templates. That is, you won't know which `FunctionDecl` you will get: the template or the instantiation. And you might need one or the other specifically.

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware added a comment. I will run it, once we are approaching the final version. This one is more of a question than a real patch. http://reviews.llvm.org/D19357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Please be sure to run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well. http://reviews.llvm.org/D19357 ___ cfe-commits mailing list cfe-com

[PATCH] D19357: [ASTMatchers] New matcher forFunction

2016-04-21 Thread Balogh , Ádám via cfe-commits
baloghadamsoftware created this revision. baloghadamsoftware added a reviewer: sbenza. baloghadamsoftware added subscribers: cfe-commits, xazax.hun, o.gyorgy. Herald added a subscriber: klimek. Matcher proposed in the review of checker misc-assign-operator (name pending). Its goal is to find the