Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-24 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267368: clang-format: [JS] generator and async functions. (authored by mprobst). Changed prior to commit: http://reviews.llvm.org/D19204?vs=54195&id=54814#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-24 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D19204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-22 Thread Martin Probst via cfe-commits
mprobst added a comment. Friendly ping. http://reviews.llvm.org/D19204 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-19 Thread Martin Probst via cfe-commits
mprobst marked an inline comment as done. Comment at: unittests/Format/FormatTestJS.cpp:339 @@ +338,3 @@ +TEST_F(FormatTestJS, AsyncFunctions) { + verifyFormat("async function f() {\n" + " let x = 1;\n" djasper wrote: > Fundamentally, I think there

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-19 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:339 @@ +338,3 @@ +TEST_F(FormatTestJS, AsyncFunctions) { + verifyFormat("async function f() {\n" + " let x = 1;\n" Fundamentally, I think there is two things we might need

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-19 Thread Martin Probst via cfe-commits
mprobst marked an inline comment as done. Comment at: unittests/Format/FormatTestJS.cpp:339 @@ +338,3 @@ + "}"); + verifyFormat("async function* f() {\n" + " yield fetch(x);\n" djasper wrote: > What does the star mean here? Should we

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-19 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 54195. mprobst added a comment. - test for wrapping http://reviews.llvm.org/D19204 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.c

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-19 Thread Daniel Jasper via cfe-commits
djasper added inline comments. Comment at: unittests/Format/FormatTestJS.cpp:339 @@ +338,3 @@ + "}"); + verifyFormat("async function* f() {\n" + " yield fetch(x);\n" What does the star mean here? Should we actually introduce a token t

Re: [PATCH] D19204: clang-format: [JS] generator and async functions.

2016-04-17 Thread Martin Probst via cfe-commits
mprobst updated this revision to Diff 54017. mprobst added a comment. - fix tests - add spec links http://reviews.llvm.org/D19204 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp lib/Format/UnwrappedLineParser.cpp unittests/Format/Forma