[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-11-15 Thread Cameron via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL286973: [clang-format] Fixed line merging of more than two lines (authored by cameron314). Changed prior to commit: https://reviews.llvm.org/D19063?vs=53572&id=77996#toc Repository: rL LLVM https://

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-10-06 Thread Cameron via cfe-commits
cameron314 added a comment. I'll commit this in a few days, when I have some time to reintegrate it to the trunk. Thanks! https://reviews.llvm.org/D19063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-10-04 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Sorry for the delay. Looks good. https://reviews.llvm.org/D19063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic added inline comments. Comment at: unittests/Format/FormatTest.cpp:285 @@ +284,3 @@ + + EXPECT_EQ("class Foo\n" +"{\n" djasper wrote: > How does this break? I generally add an Before and After of one of the test > cases into my patch descr

Re: [PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Daniel Jasper via cfe-commits
djasper added a comment. Nice catch. Comment at: unittests/Format/FormatTest.cpp:285 @@ +284,3 @@ + + EXPECT_EQ("class Foo\n" +"{\n" How does this break? I generally add an Before and After of one of the test cases into my patch descriptions. htt

[PATCH] D19063: clang-format: Fixed line merging of more than two lines

2016-04-13 Thread Maxime Beaulieu via cfe-commits
mxbOctasic created this revision. mxbOctasic added a reviewer: djasper. mxbOctasic added subscribers: cameron314, cfe-commits. Herald added a subscriber: klimek. `getNextMergedLine` merged pairs of adjacent lines instead of merging them all with the first one. Consider `AnnotatedLine` `A`, `B` a