This revision was automatically updated to reflect the committed changes.
Closed by commit rL268344: Adding a test for a compiler crash that was fixed in
r248069. (authored by dyung).
Changed prior to commit:
http://reviews.llvm.org/D19048?vs=55495&id=55925#toc
Repository:
rL LLVM
http://re
aprantl added a comment.
Please make sure that the two DINodes are connected, otherwise LGTM. Thanks!
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dyung updated this revision to Diff 55495.
dyung added a comment.
Fixed up test and check for that DIImportedEntity and DIModule are present in
the generated output.
http://reviews.llvm.org/D19048
Files:
test/Modules/Inputs/getSourceDescriptor-crash/h1.h
test/Modules/Inputs/getSourceDescri
dyung added inline comments.
Comment at: test/Modules/getSourceDescriptor-crash.cpp:6
@@ +5,2 @@
+
+// CHECK: DIModule2
aprantl wrote:
> This doesn't actually appear in the output :-)
> You probably want to at least check for the correct name of the module and
>
aprantl added inline comments.
Comment at: test/Modules/getSourceDescriptor-crash.cpp:6
@@ +5,2 @@
+
+// CHECK: DIModule2
This doesn't actually appear in the output :-)
You probably want to at least check for the correct name of the module and for
the DIImportedE
dyung updated this revision to Diff 55460.
dyung added a comment.
Change test to not use the driver.
http://reviews.llvm.org/D19048
Files:
test/Modules/Inputs/getSourceDescriptor-crash/h1.h
test/Modules/Inputs/getSourceDescriptor-crash/module.modulemap
test/Modules/getSourceDescriptor-cra
dyung updated this revision to Diff 55457.
dyung added a comment.
Modified the test to emit llvm assembly and check for the presence of a
DIModule in the output.
http://reviews.llvm.org/D19048
Files:
test/Modules/Inputs/getSourceDescriptor-crash/h1.h
test/Modules/Inputs/getSourceDescriptor
> On Apr 27, 2016, at 7:27 PM, Douglas Yung wrote:
>
> dyung added a comment.
>
> In http://reviews.llvm.org/D19048#414568, @aprantl wrote:
>
>> Thanks!
>>
>> Is there anything meaningful that could be CHECKed here?
>> Usually a crash means that we previously had a code path without test
>>
probinson added a subscriber: probinson.
Comment at: test/Modules/getSourceDescriptor-crash.cpp:1
@@ +1,2 @@
+// RUN: %clang -I %S/Inputs/getSourceDescriptor-crash -c -g
-fimplicit-module-maps %s
+
Should run %clang_cc1 not the driver.
http://reviews.llvm.org/
dyung added a comment.
In http://reviews.llvm.org/D19048#414568, @aprantl wrote:
> Thanks!
>
> Is there anything meaningful that could be CHECKed here?
> Usually a crash means that we previously had a code path without test
> coverage.
This was definitely a code path without test coverage.
W
aprantl added a comment.
Thanks!
Is there anything meaningful that could be CHECKed here?
Usually a crash means that we previously had a code path without test coverage.
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.
dyung added a comment.
ping
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dyung added a comment.
Any thoughts on this test?
http://reviews.llvm.org/D19048
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dyung created this revision.
dyung added a reviewer: aprantl.
dyung added a subscriber: cfe-commits.
In our internal testing, we found a crash in the compiler which was reduced to
the attached test case. The issue was "fixed" a while back with Adrian's change
in r248069 as the code causing the c
14 matches
Mail list logo
