Re: [PATCH] D18956: [Sema] Fix assertion failure at vector comparison

2016-04-14 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I agree. In the example, the type of `y == z` should be `vec`, not `int` -- we should "promote" to the vector type. Repository: rL LLVM http://reviews.llvm.org/D18956

Re: [PATCH] D18956: [Sema] Fix assertion failure at vector comparison

2016-04-14 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. rnk added a comment. I think Sema::CheckVectorOperands isn't supposed to return a scalar type. Fixing that with http://reviews.llvm.org/D19123 also solves this problem. Richard, WDYT? Repository: rL LLVM http://reviews.llvm.org/D18956