Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-07-07 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Sorry for the delay. Your patch was lost in my inbox. Feel free to ping me earlier. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-06-04 Thread Piotr Padlewski via cfe-commits
Prazek added inline comments. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as return type. +If check finds case like this then it function retu

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-06-03 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:37 @@ +36,3 @@ + +It turns out that the common bug is to have function returning only bools but having int as retur

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-06-01 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. ping http://reviews.llvm.org/D18821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-30 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 58961. Prazek added a comment. aborting with virtual functions http://reviews.llvm.org/D18821 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp clang-tidy/bugprone/BoolToIntegerConversionCheck.h clang-tidy/bugprone

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-24 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 58309. Prazek added a comment. Some small bugfixes afeter running it on llvm http://reviews.llvm.org/D18821 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp clang-tidy/bugprone/BoolToIntegerConversionCheck.h clang

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-23 Thread Piotr Padlewski via cfe-commits
Prazek updated this revision to Diff 58148. Prazek added a comment. +Fixed bug with operators + added fixup for function return type I will post changes on clang tomorrow http://reviews.llvm.org/D18821 Files: clang-tidy/CMakeLists.txt clang-tidy/bugprone/BoolToIntegerConversionCheck.cpp

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-17 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: docs/clang-tidy/checks/bugprone-bool-to-integer-conversion.rst:43 @@ +42,3 @@ + +This is because z and ``true`` will be implicitly converted to int by promotion. +To get rid of t

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-05 Thread Piotr Padlewski via cfe-commits
Prazek added a comment. Updated the diff with changes http://reviews.llvm.org/D19105 http://reviews.llvm.org/D18821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18821: Add bugprone-bool-to-integer-conversion

2016-05-04 Thread Piotr Padlewski via cfe-commits
Prazek retitled this revision from "Add modernize-bool-to-integer-conversion" to "Add bugprone-bool-to-integer-conversion". Prazek updated this revision to Diff 56138. Prazek added a comment. It seems that it works right now. The other funny thing that the check found is cases like bool b; if (b