This revision was automatically updated to reflect the committed changes.
Closed by commit rL265314: Document standard substitutions defined by lit.
(authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D18752?vs=52531&id=52578#toc
Repository:
rL LLVM
http://reviews.llvm
RedX2501 added a comment.
Thanks for the advice.
Please use Guilherme Bufolo as the name for the commit.
Am 04.04.2016 21:33 schrieb "Paul Robinson" <
paul_robin...@playstation.sony.com>:
> probinson added a subscriber: probinson.
> probinson added a comment.
>
> In http://reviews.llvm.org/
probinson added a subscriber: probinson.
probinson added a comment.
In http://reviews.llvm.org/D18752#390906, @RedX2501 wrote:
> Somebody else needs to commit this as I don't have any rights for it.
When someone else commits for you, our practice is to attribute the correct
author in the commi
RedX2501 updated this revision to Diff 52531.
RedX2501 added a comment.
I had a hard time myself figuring out what tmpbase and tmpdir are. I have used
your wording.
Somebody else needs to commit this as I don't have any rights for it.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/
MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.
I'd probably go for a term like "pattern" instead of macro (there is no
parameters or anything more complicated). The explanation for %t/%T is not
helpful in the current form. Maybe something
RedX2501 updated this revision to Diff 52530.
RedX2501 added a comment.
Added reference to testing infrastructure document.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/lit.rst
Index: docs/CommandGuide/lit.rst
===
---
MatzeB added a comment.
Most patterns and several of the ones coming from lit.local.cfg are explained
in TestingGuide.rst as well. On the other hand it makes sense to explain the
lit specific substitutions in the lit docu, maybe just add an additional link
to the TestingGuide.rst to reference t
RedX2501 created this revision.
RedX2501 added reviewers: EricWF, MatzeB, echristo, jroelofs.
RedX2501 added a subscriber: cfe-commits.
http://reviews.llvm.org/D18752
Files:
docs/CommandGuide/lit.rst
Index: docs/CommandGuide/lit.rst
=
