Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Filipe Cabecinhas via cfe-commits
filcab abandoned this revision. filcab added a comment. Thanks for clarifying, Richard. I'll think about getting some fixes/tests in for our DRs. http://reviews.llvm.org/D18654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Richard Smith via cfe-commits
rsmith added a comment. In http://reviews.llvm.org/D18654#388419, @filcab wrote: > That means that our C++11 mode will have some fixes, right? Right. The standard's rules are often incoherent or unimplementable without the fixes in DRs, so it's not meaningful to implement ISO C++ as standardiz

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Filipe Cabecinhas via cfe-commits
That means that our C++11 mode will have some fixes, right? How can we call what out C++11 mode is? Are there updated versions of the standard? Are there lists of defects that we have fixed and others we haven't? Sorry, I'm not too familiar with how the standard+fixes usually work. Thank you,

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Filipe Cabecinhas via cfe-commits
filcab added a subscriber: filcab. filcab added a comment. That means that our C++11 mode will have some fixes, right? How can we call what out C++11 mode is? Are there updated versions of the standard? Are there lists of defects that we have fixed and others we haven't? Sorry, I'm not too famili

Re: [PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Richard Smith via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. Core issue 1457 is a DR against C++11, so it applies to our C++11 mode. http://reviews.llvm.org/D18654 ___ cfe-commits mailing list cfe

[PATCH] D18654: In C++11 it is undefined to shift into the sign bit

2016-03-31 Thread Filipe Cabecinhas via cfe-commits
filcab created this revision. filcab added reviewers: rsmith, samsonov. filcab added a subscriber: cfe-commits. Clang was using C++14 rules for shifts into the sign bit with any C++ standard. Now it has the C++ <14 special case (same as C). Using this C++11 standard draft as reference (before CWG