betulb added a comment.
Committed as r265037.
Repository:
rL LLVM
http://reviews.llvm.org/D18636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
betulb removed rL LLVM as the repository for this revision.
betulb updated this revision to Diff 52249.
betulb added a comment.
Addressed review comments.
http://reviews.llvm.org/D18636
Files:
lib/CodeGen/CodeGenPGO.cpp
test/Profile/c-avoid-direct-call.c
Index: test/Profile/c-avoid-direct-
Betul Buyukkurt writes:
> betulb created this revision.
> betulb added reviewers: davidxl, bogner.
> betulb added subscribers: llvm-commits, cfe-commits.
> betulb set the repository for this revision to rL LLVM.
> betulb changed the visibility of this Differential Revision from
> "Public (No Login
betulb added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ if (dyn_cast(ValuePtr))
+return;
davidxl wrote:
> Is it the bitcast guaranteed to be already stripped here?
No. ConstantExpr is derived from the Constant class. A
davidxl added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:758
@@ -757,1 +757,3 @@
+ if (dyn_cast(ValuePtr))
+return;
Is it the bitcast guaranteed to be already stripped here?
Repository:
rL LLVM
http://reviews.llvm.org/D18636
___
betulb created this revision.
betulb added reviewers: davidxl, bogner.
betulb added subscribers: llvm-commits, cfe-commits.
betulb set the repository for this revision to rL LLVM.
betulb changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
Value p
