sfantao updated this revision to Diff 58651.
sfantao added a comment.
- Mark MappableVarListInfo as final.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Basic/OpenMP
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG, with a small nit.
Comment at: lib/Sema/SemaOpenMP.cpp:10214
@@ +10213,3 @@
+// expressions.
+struct MappableVarListInfo {
+ // The list of expressions.
sfantao updated this revision to Diff 58486.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Address comments from the last review by Alexey.
http://reviews.llvm.org/D18597
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/B
sfantao added a comment.
Hi Alexey,
Thanks for the review.
Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220
@@ +10217,5 @@
+Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind,
+ArrayRef VarList, SmallVector &Vars,
+OMPClauseMappableExprCommon::MappableExprCompon
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:10218-10220
@@ +10217,5 @@
+Sema &SemaRef, DSAStackTy *DSAS, OpenMPClauseKind CKind,
+ArrayRef VarList, SmallVector &Vars,
+OMPClauseMappableExprCommon::MappableExprComponentLists &ClauseComponents,
+
sfantao updated this revision to Diff 58370.
sfantao added a comment.
Add implementation and tests only for the `to` clause. The implementation is
based on the existing infrastructure used by the `map` clause already available
upstream.
http://reviews.llvm.org/D18597
Files:
include/clang/AS
