Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-06 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin closed this revision. DmitryPolukhin added a comment. Committed as http://reviews.llvm.org/rL265530 http://reviews.llvm.org/D18542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-05 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin updated this revision to Diff 52690. DmitryPolukhin marked 8 inline comments as done. DmitryPolukhin added a comment. - fixed all comments - rebase Aaron and Alexey, thank you for the review! http://reviews.llvm.org/D18542 Files: include/clang/AST/ASTMutationListener.h inclu

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-05 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. Just some very minor nits, otherwise LGTM! Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7931 @@ +7930,3 @@ +def err_omp_enclosed_declare_target : Error< + "declare target region may not be enclosed i

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-05 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D18542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-05 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin added a comment. Alexey, please review OpenMP specific things. Aaron, are you OK with the attribute implementation and printing approach? http://reviews.llvm.org/D18542 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-04-01 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin updated this revision to Diff 52349. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. - implemented ad hoc solution for printing - added documentation for the attrbute - reabse In http://reviews.llvm.org/D18542#388241, @aaron.ballman wrote: > If you

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-03-31 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D18542#387934, @DmitryPolukhin wrote: > Could you please take a look to OMPDeclareTargetDecl attribute implementation > and printPrettyEnd approach in general? > For post print mechanism alternative approach is to use ad hoc solution in

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-03-31 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin added a comment. Aaron, Could you please take a look to OMPDeclareTargetDecl attribute implementation and printPrettyEnd approach in general? For post print mechanism alternative approach is to use ad hoc solution in DeclPrinter. Thanks, Dmitry Software Engineer Intel Compiler

Re: [PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-03-30 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin updated this revision to Diff 52070. DmitryPolukhin added a comment. - Added test for templates in declare target region http://reviews.llvm.org/D18542 Files: include/clang/AST/ASTMutationListener.h include/clang/AST/Attr.h include/clang/Basic/Attr.td include/clang/Basic/

[PATCH] D18542: [OPENMP] Parsing and Sema support for 'omp declare target' directive

2016-03-29 Thread Dmitry Polukhin via cfe-commits
DmitryPolukhin created this revision. DmitryPolukhin added reviewers: ABataev, aaron.ballman. DmitryPolukhin added subscribers: cfe-commits, fraggamuffin. Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0 (4.5 support will be added in separate patch). The declare target dir