[PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2019-03-20 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood abandoned this revision. LegalizeAdulthood added a comment. Herald added a reviewer: serge-sans-paille. Review takes too long to make forward progress; abandoning. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18509/new/ https://reviews.llvm.org/D18509 _

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-04-06 Thread Etienne Bergeron via cfe-commits
etienneb added a subscriber: etienneb. etienneb added a comment. I like this :) http://reviews.llvm.org/D18509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-04-04 Thread Richard via cfe-commits
LegalizeAdulthood added a comment. In http://reviews.llvm.org/D18509#388071, @hintonda wrote: > With this change, won't you need to update 2 different repos: clang and > extra? Is it possible to update both with a single Phabricator patch? This is updating the release notes in the extra repos

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-31 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D18509#388071, @hintonda wrote: > With this change, won't you need to update 2 different repos: clang and > extra? Is it possible to update both with a single Phabricator patch? Clang-tidy release notes are now in the clang-tools-extra reposi

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-31 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please use single ` around check name and also add link. See http://reviews.llvm.org/D18582 as example. http://reviews.llvm.org/D18509 ___ cfe-commits mailing list c

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-31 Thread don hinton via cfe-commits
hintonda added a subscriber: hintonda. hintonda added a comment. With this change, won't you need to update 2 different repos: clang and extra? Is it possible to update both with a single Phabricator patch? http://reviews.llvm.org/D18509 ___ cfe-c

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-31 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. I like the idea, but we could make this a bit more reliable, see the inline comment. Comment at: clang-tidy/add_new_check.py:280 @@ +279,3 @@ + if not clang_tidy_found: +if line.startswith("Improvements to ``clang-tidy``"): + clang_

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-30 Thread Richard via cfe-commits
LegalizeAdulthood added inline comments. Comment at: clang-tidy/add_new_check.py:283 @@ +282,3 @@ + elif not clang_tidy_heading_found: +if line.startswith('^^'): + clang_tidy_heading_found = True Alex changed the f

[PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

2016-03-27 Thread Richard via cfe-commits
LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. LegalizeAdulthood added a subscriber: cfe-commits. Update `add_new_check.py` to stub out information in the release notes for the new check. http://reviews.llvm.org/D18509 Files: clang-tidy/add_new_check.py