Re: [PATCH] D18501: Fix compilation on FreeBSD

2016-04-02 Thread Dimitry Andric via cfe-commits
dim abandoned this revision. dim added a comment. Yes, this was indeed the wrong include order. During the latter stages of FreeBSD's buildworld, the compiler is invoked with `-nostdinc++`, but `/usr/include` was put before the libc++ include directory, `/usr/include/c++/v1`. So as @rsmith re

Re: [PATCH] D18501: Fix compilation on FreeBSD

2016-03-30 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith added a comment. libc++'s converts the `signbit` macro into a function. If you're not seeing a function here, that suggests your include paths are messed up and the C library is being found before libc++'s . http://reviews.llvm.org/D18501

Re: [PATCH] D18501: Fix compilation on FreeBSD

2016-03-30 Thread Eric Fiselier via cfe-commits
EricWF added a comment. In http://reviews.llvm.org/D18501#384285, @dim wrote: > Note that these compilation errors came up specifically because @bdrewery is > doing cross-compilation of FreeBSD with recent versions of gcc. Apparently > clang does not give the same errors on these undefined ide

Re: [PATCH] D18501: Fix compilation on FreeBSD

2016-03-27 Thread Dimitry Andric via cfe-commits
dim added a comment. Note that these compilation errors came up specifically because @bdrewery is doing cross-compilation of FreeBSD with recent versions of gcc. Apparently clang does not give the same errors on these undefined identifiers, but I'm not entirely sure why not... http://reviews

[PATCH] D18501: Fix compilation on FreeBSD

2016-03-27 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: mclow.lists, EricWF, emaste. dim added subscribers: cfe-commits, bdrewery. Herald added a subscriber: emaste. On FreeBSD, a number of math.h functions are actually defined as macros, such as `signbit()`, `fpclassify()` and others. Since libc++'s at