shafik added a comment.
Herald added a subscriber: arphaman.
Herald added a project: All.
@compnerd is this still relevant?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D18478/new/
https://reviews.llvm.org/D18478
___
cfe-commits mailing list
compnerd accepted this revision.
compnerd added a subscriber: jbcoe.
compnerd added a comment.
This revision is now accepted and ready to land.
This would ideally wait for the change that @jbcoe has in the works to enable
python 3, but the change itself is fine.
https://reviews.llvm.org/D18478
compnerd added a comment.
Hmm, could do something devious. Write the test and run that through the c
preprocessor and then use that to compare the string. Ugly, but would be
completely generic and ensure that we see the value we expect always.
https://reviews.llvm.org/D18478
_
john.tornblom added a comment.
Any suggestions on how to test this? Just check for non-empty string?
http://reviews.llvm.org/D18478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
john.tornblom created this revision.
john.tornblom added reviewers: eliben, compnerd.
john.tornblom added a subscriber: cfe-commits.
http://reviews.llvm.org/D18478
Files:
bindings/python/clang/cindex.py
Index: bindings/python/clang/cindex.py
