This revision was automatically updated to reflect the committed changes.
Closed by commit rL290172: Fix for clang_Cursor_getSpellingNameRange()
(authored by kfunk).
Changed prior to commit:
https://reviews.llvm.org/D18462?vs=51608&id=82071#toc
Repository:
rL LLVM
https://reviews.llvm.org/D
bkramer accepted this revision.
bkramer added a comment.
looks good from my side.
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw accepted this revision.
milianw added a comment.
This revision is now accepted and ready to land.
agreed, lgtm but someone else must accept this upstream
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kfunk added a comment.
@other LLVM devs: Please review so we can finally ship this?
Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+ C.kind == CXCursor_ConversionFunction ||
+ C.kind == CXCursor_FunctionDecl) {
if (pieceIndex > 0)
---
klimek added a reviewer: bkramer.
klimek added a comment.
+Benjamin
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw added a comment.
ping, any update on this?
https://reviews.llvm.org/D18462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
skalinichev added inline comments.
Comment at: tools/libclang/CIndex.cpp:4311
@@ -4311,1 +4310,3 @@
+ C.kind == CXCursor_ConversionFunction ||
+ C.kind == CXCursor_FunctionDecl) {
if (pieceIndex > 0)
What about function templates?
E.g.: template d
