Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

2016-03-25 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL26: [ObjCXX] Warn undeclared identifiers. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D18461?vs=51598&id=51667#toc Repository: rL LLVM http://reviews.llvm.org/D18461 Fi

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

2016-03-25 Thread Manman Ren via cfe-commits
manmanren added a comment. In http://reviews.llvm.org/D18461#383218, @rjmccall wrote: > Oh, you know, this should really propagate all the dependence bits, not just > instantiation-dependence. It would be safer, at least. You could probably > find a contrived example involving value-dependenc

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

2016-03-24 Thread John McCall via cfe-commits
rjmccall added a comment. Oh, you know, this should really propagate all the dependence bits, not just instantiation-dependence. It would be safer, at least. You could probably find a contrived example involving value-dependence. http://reviews.llvm.org/D18461

Re: [PATCH] D18461: ObjCXX: Warn undeclared identifiers.

2016-03-24 Thread John McCall via cfe-commits
rjmccall added a comment. LGTM. http://reviews.llvm.org/D18461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18461: ObjCXX: Warn undeclared identifiers.

2016-03-24 Thread Manman Ren via cfe-commits
manmanren created this revision. manmanren added reviewers: rsmith, rjmccall. manmanren added a subscriber: cfe-commits. Instantiation dependence were not being handled correctly for OpqaueValueExpr AST nodes. As a result, if an undeclared identifier was used in a CXXNewExpr that is assigned to a