Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. …and landed in r264174. http://reviews.llvm.org/D18401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Nico Weber via cfe-commits
thakis updated this revision to Diff 51448. thakis marked 2 inline comments as done. thakis added a comment. Thanks! All done. http://reviews.llvm.org/D18401 Files: lib/Frontend/CompilerInstance.cpp lib/Frontend/HeaderIncludeGen.cpp lib/Frontend/InitPreprocessor.cpp test/Driver/cl-pch-s

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. This revision is now accepted and ready to land. Comment at: lib/Frontend/HeaderIncludeGen.cpp:155-156 @@ -151,3 +154,4 @@ // Dump the header include information we are past the

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Nico Weber via cfe-commits
thakis updated the summary for this revision. thakis updated this revision to Diff 51442. http://reviews.llvm.org/D18401 Files: lib/Frontend/CompilerInstance.cpp lib/Frontend/HeaderIncludeGen.cpp lib/Frontend/InitPreprocessor.cpp test/Driver/cl-pch-showincludes.cpp test/Frontend/print-h

Re: [PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Nico Weber via cfe-commits
thakis added a comment. On second thought, and after looking at -E output with -include and gch files, and at CC_PRINT_HEADERS behavior (it prints but doesn't indent), I think I like the alternative implementation I'm mentioning better. Let me make that change. http://reviews.llvm.org/D18401

[PATCH] D18401: clang-cl: Include /FI headers in /showIncludes output.

2016-03-23 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. `-H` in gcc mode doesn't print `-include` headers, but they are included in depfiles written by MMD and friends. Since `/showIncludes` is what's used instead of depfiles, printing `/FI` there see