EricWF closed this revision.
EricWF added a comment.
This was committed in r264191.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
richard.barton.arm added a comment.
Hi Eric - no problem at all, you practically wrote it for me after all ;-)
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks for the complete patch! The "no-threads" bot should now be green
so future breakage will be detected immediately!
http://reviews.llvm.org/D18347
__
richard.barton.arm updated this revision to Diff 51409.
richard.barton.arm added a comment.
My local run with no threads works with this updated patch.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
test/libcxx/thread/thr
jamesr added a comment.
In http://reviews.llvm.org/D18347#380792, @EricWF wrote:
> And looking at the current state of the single-threaded test suite this isn't
> the only test that needs this fix applied.
>
> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/
richard.barton.arm added a comment.
Thanks for the help Eric. I'm just running a new patch now will put the new
patch up when I get back in to office tomorrow.
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
EricWF added a comment.
And looking at the current state of the single-threaded test suite this isn't
the only test that needs this fix applied.
http://lab.llvm.org:8011/builders/libcxx-libcxxabi-singlethreaded-x86_64-linux-debian/builds/869
http://reviews.llvm.org/D18347
__
EricWF added a comment.
I think the correct fix is "// UNSUPPORTED: libcpp-has-no-threads"
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
richard.barton.arm added a comment.
Hi Eric
Sorry for the delay - I originally detected the failure while not running in a
totally clean environment with clean sources, but I can reproduce on clean code.
I can reproduce by building with clean clang and libcxx sources:
cmake -DLLVM_PATH=/work/ri
EricWF added a comment.
I don't actually understand this change. This test should compile with or
without "-Wthread-safety" warning. This test doesn't actually turn the
annotations on, that's the point. If annotations were actually enabled this
test would fail to compile.
Could you explain the
richard.barton.arm updated this revision to Diff 51316.
richard.barton.arm added a comment.
Sorry - not sure what happened there. That looks better for me.
http://reviews.llvm.org/D18347
Files:
test/libcxx/thread/thread.mutex/thread_safety_annotations_not_enabled.pass.cpp
Index:
test/libcxx
EricWF requested changes to this revision.
EricWF added a comment.
This revision now requires changes to proceed.
I think this diff is messed up a little. Could you upload a fixed diff?
http://reviews.llvm.org/D18347
___
cfe-commits mailing list
cf
richard.barton.arm created this revision.
richard.barton.arm added reviewers: EricWF, jamesr.
richard.barton.arm added a subscriber: cfe-commits.
Although not testing the annotations feature, the test still needs guarding for
thread-safety otherwise it will not compile at all.
http://reviews.llv
13 matches
Mail list logo
