Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in r264092.
https://reviews.llvm.org/D18325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D18325
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
jtsoftware edited reviewers, added: rsmith; removed: probinson, silvas.
jtsoftware updated this revision to Diff 51313.
jtsoftware added a comment.
Right. Also undoing moving stuff around. How about this? Thanks.
http://reviews.llvm.org/D18325
Files:
lib/Headers/module.modulemap
test/Hea
rsmith added a subscriber: rsmith.
Comment at: lib/Headers/module.modulemap:48
@@ -47,3 +47,1 @@
- export mmx
- export sse2 // note: for hackish dependency
header "xmmintrin.h"
Did you intentionally remove this comment?
Comment
jtsoftware created this revision.
jtsoftware added reviewers: silvas, probinson.
jtsoftware added a subscriber: cfe-commits.
If someone only includes xmmintrin.h, but references any definitions from
stdlib.h (included via mm_malloc.h), if module are enabled it will fail, but if
modules are not e