Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Etienne Bergeron via cfe-commits
> hasAnyName() was added mostly for performance reasons. Fair enough. Thanks. On Fri, Mar 25, 2016 at 2:01 PM, Samuel Benzaquen wrote: > On Fri, Mar 25, 2016 at 1:55 PM, Etienne Bergeron > wrote: > >> etienneb added a subscriber: etienneb. >> etienneb added a comment. >> >> Any plan for doing

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Samuel Benzaquen via cfe-commits
On Fri, Mar 25, 2016 at 1:55 PM, Etienne Bergeron wrote: > etienneb added a subscriber: etienneb. > etienneb added a comment. > > Any plan for doing the same for : hasOverloadedOperatorName ? > hasAnyName() was added mostly for performance reasons. We could add the 'Any' version of hasOverloaded

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Etienne Bergeron via cfe-commits
etienneb added a subscriber: etienneb. etienneb added a comment. Any plan for doing the same for : hasOverloadedOperatorName ? Repository: rL LLVM http://reviews.llvm.org/D18275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-25 Thread Samuel Benzaquen via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL264417: [ASTMatchers] Add own version of VariadicFunction. (authored by sbenza). Changed prior to commit: http://reviews.llvm.org/D18275?vs=51447&id=51645#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-23 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Still LG. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:82 @@ +81,3 @@ + ResultT operator()(ArrayRef Args) const { +SmallVector InnerArgs; +for (const ArgT &Arg : Args) > On the other hand, constructing the matchers

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-23 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80 @@ +79,3 @@ + ResultT operator()(ArrayRef Args) const { +std::vector InnerArgs; +for (const ArgT &Arg : Args) alexfh wrote: > It's unfortunate that we need to cre

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-23 Thread Samuel Benzaquen via cfe-commits
sbenza updated this revision to Diff 51447. sbenza added a comment. Minor fix http://reviews.llvm.org/D18275 Files: include/clang/ASTMatchers/ASTMatchers.h include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Marshallers.h unittests/ASTMatchers/ASTMatchersTest.cpp In

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-22 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:80 @@ +79,3 @@ + ResultT operator()(ArrayRef Args) const { +std::vector InnerArgs; +for (const ArgT &Ar

Re: [PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-18 Thread Samuel Benzaquen via cfe-commits
sbenza added a comment. Alex, this is what we discussed to make `hasAnyName` take a `vector` directly. http://reviews.llvm.org/D18275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18275: [ASTMatchers] Add own version of VariadicFunction.

2016-03-18 Thread Samuel Benzaquen via cfe-commits
sbenza created this revision. sbenza added a reviewer: alexfh. sbenza added a subscriber: cfe-commits. Herald added a subscriber: klimek. llvm::VariadicFunction is only being used by ASTMatchers. Having own copy here allows us to remove the other one from llvm/ADT. Also, we can extend the API to o