Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

2016-03-19 Thread Jonas Hahnfeld via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263699: [libcxxabi] Disable cxa_thread_atexit_test if unavailable (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D18205?vs=50805&id=50916#toc Repository: rL LLVM http://rev

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

2016-03-19 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld added inline comments. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if self.get_lit_bool('thread_atexit', False): +self.config.available_features.add('thread_atexit') ---

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

2016-03-19 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after the inline question is addressed. Comment at: test/libcxxabi/test/config.py:38 @@ +37,3 @@ +super(Configuration, self).configure_features() +if self

[PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

2016-03-16 Thread Jonas Hahnfeld via cfe-commits
Hahnfeld created this revision. Hahnfeld added reviewers: EricWF, danalbert. Hahnfeld added a subscriber: cfe-commits. The feature check is already in place when building the library but wasn't honored for the tests. http://reviews.llvm.org/D18205 Files: test/CMakeLists.txt test/cxa_thread_