pcc added subscribers: majnemer, rnk.
pcc added a comment.
Done (this also affects `_purecall` in the MS ABI; I don't think this change
should break anything there, but someone working on that might want to
comment). Since this patch is now specific to virtual tables anyway, I've
incorporated a
pcc updated this revision to Diff 50500.
pcc added a comment.
Restrict to functions referenced in virtual tables
http://reviews.llvm.org/D18071
Files:
lib/CodeGen/CGVTables.cpp
lib/CodeGen/CodeGenModule.cpp
test/CodeGenCXX/virtual-function-attrs.cpp
test/CodeGenCXX/vtt-layout.cpp
Index
rjmccall added a comment.
The underscore check seems over-broad; we support a lot of language dialects
and runtimes besides the Itanium C++ runtime. This would be both more
conservative and more convincing if it were constrained to the functions that
we expect to put in v-tables.
http://revi
pcc created this revision.
pcc added reviewers: rsmith, rjmccall.
pcc added a subscriber: cfe-commits.
User programs shouldn't be able to observe their addresses without invoking
undefined behavior. This will be needed to create relative references
to runtime functions __cxa_pure_virtual and __cxa
