alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you for addressing the comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:117
@@ +116,3 @@
+static llvm::SmallDenseMap createRelativeCharSi
baloghadamsoftware marked 9 inline comments as done.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:117
@@ +116,3 @@
+static llvm::SmallDenseMap createRelativeCharSizesMap() {
+ llvm::SmallDenseMap Result(6);
+ Result[BuiltinType::UChar] = 1;
I chang
baloghadamsoftware updated this revision to Diff 51633.
baloghadamsoftware added a comment.
Requested revision done.
http://reviews.llvm.org/D17987
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
clang-tidy/misc/MisplacedWideningCastCheck.cpp
clang-tidy/misc/MisplacedWidenin
alexfh added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:116
@@ +115,3 @@
+
+ if (RelativeIntSizes.find(First) != RelativeIntSizes.end() &&
+ RelativeIntSizes.find(Second) != RelativeIntSizes.end()) {
This code shouldn't repea
baloghadamsoftware updated this revision to Diff 51418.
baloghadamsoftware added a comment.
Required fixes done.
http://reviews.llvm.org/D17987
Files:
clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp
clang-tidy/misc/MisplacedWideningCastCheck.cpp
clang-tidy/misc/MisplacedWideningCas
baloghadamsoftware added inline comments.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:119
@@ -98,4 +118,3 @@
if (Context.getIntWidth(CastType) == Context.getIntWidth(CalcType)) {
-if (CalcType->isSpecificBuiltinType(BuiltinType::Int) ||
-CalcType->isS
alexfh added inline comments.
Comment at: clang-tidy/misc/BoolPointerImplicitConversionCheck.cpp:64
@@ -63,3 +63,3 @@
// bool.
- !match(findAll(callExpr(hasAnyArgument(DeclRef))), *If, *Result.Context)
+
!match(findAll(callExpr(hasAnyArgument(ignoringParenImpCast
baloghadamsoftware added a comment.
Prerequisites (matchers) are accepted now.
http://reviews.llvm.org/D17987
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
